feat: custom regex rule #102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: SHA65536 <[email protected]>
Signed-off-by: SHA65536 <[email protected]>
Signed-off-by: SHA65536 <[email protected]>
Signed-off-by: SHA65536 <[email protected]>
jossef
requested changes
Jun 22, 2023
Signed-off-by: SHA65536 <[email protected]>
jossef
approved these changes
Jun 23, 2023
|
assigning @baruchiro to resolve his comments and merge if lgtm |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
added 2 commits
June 23, 2023 14:12
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #98
Proposed Changes
--regexflag on the main command to let the user supply a custom regex ruleI tested this with the filesystem plugin, but did not try with other plugins, would love if someone could test
I submit this contribution under the Apache-2.0 license.