Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: option to load arguments from config file #107

Merged
merged 34 commits into from
Jun 29, 2023
Merged

feat: option to load arguments from config file #107

merged 34 commits into from
Jun 29, 2023

Conversation

baruchiro
Copy link
Contributor

  • bind flags from viper to cobra command
  • add tests
  • test for Execute
  • support multiple config formats
  • update readme with help message
  • document configuration env and file

Closes #21

Proposed Changes

  • feat: read arguments from Environment Variables
  • feat: read arguments from JSON/YAML file
  • docs: auto-update the README when the help message was changed
  • docs: how to use arguments from Environment Variables or config file

Limitations

  • You still can run only one plugin at a time.
  • You have to add the plugin command to the CLI command.
  • Positional arguments are not yet supported.

Baruch Odem added 26 commits June 13, 2023 12:40
bind flags from viper to cobra command
37bec2a
add tests
9493f9a
set value to flag
86e7bd0
non persistent flag
5b0e904
refactor
913f875
env prefix
2bfc72f
ewsponsible env var usage
0c6625d
support lower case
dc40ee0
support sub command
555e8e3
support array
262ec27
initial read from yaml
2fb53c8
assert against final value
1d9dc74
sub-sub-command from YAML
58e3d20
tests for same flag in different levels
8d04d4d
different env var for sub command
9ed2931
use assert.Equal correctly
ed16d67
initial working (?) version of config to command
ca3e731
test for Execute
44fe729
test dubcommand
b95cbbb
refactor load config
6be8abf
support multiple config formats
e1cfa24
Merge remote-tracking branch 'origin/master' into baruchiro/option-to…
32fa987 
…-load-all-arguments-from-config-file
fix lint
ae5afa2
update readme with help message
76b1df3
document configuration env and file
ad722e9
cleanup
133811a
@baruchiro baruchiro requested a review from jossef June 25, 2023 15:30
@github-actions
Copy link

github-actions bot commented Jun 25, 2023 •
edited
Loading

kics-logo

KICS version: v1.7.0

Category Results
HIGH HIGH 0
MEDIUM MEDIUM 0
LOW LOW 1
INFO INFO 0
TRACE TRACE 0
TOTAL TOTAL 1
Metric Values
Files scanned placeholder 1
Files parsed placeholder 1
Files failed to scan placeholder 0
Total executed queries placeholder 49
Queries failed to execute placeholder 0
Execution time placeholder 2

jossef
jossef requested changes Jun 28, 2023
View reviewed changes
.github/workflows/release.yml Outdated Show resolved Hide resolved
lib/flags_test.go Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
@baruchiro baruchiro mentioned this pull request Jun 29, 2023
Open
7 tasks
@baruchiro baruchiro merged commit 127e190 into master Jun 29, 2023
@baruchiro baruchiro deleted the baruchiro/option-to-load-all-arguments-from-config-file branch June 29, 2023 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jossef jossef jossef requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

option to load all arguments from config file
2 participants
@baruchiro @jossef