feat: cross-compilation #136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
KICS version: v1.7.0
|
baruchiro
reviewed
Jul 13, 2023
baruchiro
reviewed
Jul 13, 2023
| GOARCH: amd64 | ||
| run: | | ||
| go build -ldflags "-s -w -X github.com/checkmarx/2ms/cmd.Version=$VERSION" -a -installsuffix cgo -o dist/2ms.exe main.go | ||
| zip -j dist/windows-amd64-$VERSION.zip dist/2ms.exe |
There was a problem hiding this comment.
Why zip?
It will add more steps for CI (but for sure, if it is for saving bandwidth, I understand)
baruchiro
reviewed
Jul 13, 2023
| GOARCH: amd64 | ||
| run: | | ||
| go build -ldflags "-s -w -X github.com/checkmarx/2ms/cmd.Version=$VERSION" -a -installsuffix cgo -o dist/2ms main.go | ||
| zip -j dist/macos-amd64-$VERSION.zip dist/2ms |
There was a problem hiding this comment.
I have a problem with the name containing a version.
If you keep the name the same across versions, you can download the latest artifact with a link:
https://github.com/Checkmarx/2ms/releases/latest/download/2ms.
But now, we can't use a generic link, because the filename is always changing, and we need to first fetch the latest version name, then construct the filename to download.
Also, need to update the README now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #135
I submit this contribution under the Apache-2.0 license.