Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: right fields on SARIF output #149

Merged
merged 1 commit into from
Jul 26, 2023
Merged

fix: right fields on SARIF output #149

merged 1 commit into from
Jul 26, 2023

Conversation

itay-goldraich
Copy link
Contributor

@itay-goldraich itay-goldraich commented Jul 26, 2023 •
edited by baruchiro
Loading

Close #147

Proposed Changes

  • sarif.go file changed as the issue requested
  • The fields ruleId, artifactLocation.uri got the others' values.
    -The field message.text changed to be {Rule Name} has detected secret for file {file path}

I submit this contribution under the Apache-2.0 license.

baruchiro
baruchiro approved these changes Jul 26, 2023
View reviewed changes
Copy link
Contributor

@baruchiro baruchiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you give us an example of the new SARIF output (by running go run . filesystem --path . --report-path results.sarif)?

Good work!!

@baruchiro baruchiro changed the title fix: sarif.go file changed. fix: right fields on SARIF output Jul 26, 2023
@baruchiro baruchiro added this pull request to the merge queue Jul 26, 2023
Merged via the queue into Checkmarx:master with commit a76401d Jul 26, 2023
8 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cx-monicac cx-monicac cx-monicac approved these changes

@baruchiro baruchiro baruchiro approved these changes

Assignees
No one assigned
Labels
Community
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Wrong values in Sarif format
3 participants
@itay-goldraich @baruchiro @cx-monicac