feat: discord plugin #53
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
KICS version: v1.6.13
|
baruchiro
commented
Apr 20, 2023
lib/routines.go
Outdated
Comment on lines
5
to
24
| func ParallelApply[T comparable, K comparable](items []T, f func(item T) (*[]K, error)) *[]K { | ||
| var wg sync.WaitGroup | ||
| results := []K{} | ||
| for _, item := range items { | ||
| wg.Add(1) | ||
| go func(item T) { | ||
| defer wg.Done() | ||
| result, err := f(item) | ||
| if err != nil { | ||
| return | ||
| } | ||
| if result != nil { | ||
| results = append(results, *result...) | ||
| } | ||
| }(item) | ||
| } | ||
| wg.Wait() | ||
|
|
||
| return &results | ||
| } |
There was a problem hiding this comment.
I am using a generic method to run a function on each item in a slice, in parallel, and collect the results.
baruchiro
commented
Apr 20, 2023
| flags.Duration(discordFromDateFlag, defaultDateFrom, "discord from date") | ||
| flags.Int(discordMessagesCountFlag, 0, "discord messages count") | ||
|
|
||
| cmd.MarkFlagsRequiredTogether(discordTokenFlag, discordServersFlag) |
There was a problem hiding this comment.
Note to force required flags, when they are required only if one of the DiscordPlugin flags is used.
baruchiro
commented
Apr 20, 2023
plugins/discord.go
Outdated
Comment on lines
99
to
116
| func (p *DiscordPlugin) getDiscordReady() (err error) { | ||
| p.Session, err = discordgo.New(p.Token) | ||
| if err != nil { | ||
| return err | ||
| } | ||
|
|
||
| p.Session.StateEnabled = true | ||
| ready := make(chan int) | ||
| p.Session.AddHandler(func(s *discordgo.Session, r *discordgo.Ready) { | ||
| ready <- 1 | ||
| }) | ||
| err = p.Session.Open() | ||
| if err != nil { | ||
| return err | ||
| } | ||
| <-ready | ||
| return nil | ||
| } |
There was a problem hiding this comment.
discordgo.Session loads its State. The State is required for State.User.ID, but as it loaded, we are using it also for retrieving the guilds.
|
please merge with main branch, joao made some concurrency changes |
added 2 commits
May 1, 2023 10:18
added 2 commits
May 1, 2023 14:29
…scan-a-discord-channel
jossef
approved these changes
May 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #31
Features
--discord-server, we will not loop over all the user's servers.--discord-channel, we will scan all the channels in a server.--discord-durationor--discord-messages-count(the closest one).So we will scan the threads that started in the time/limit arguments (as they are messages that scanned), and for each thread we will scan the messages in the time/limit requirements.
Questions
Compared to Confluence, which has servers and spaces, we are not scanning multiple servers in one scan.
Waits for #52