-
Notifications
You must be signed in to change notification settings - Fork 307
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Please use Docker instead of downloading manually the files #2962
Comments
For example, for Gitlab: image: docker:git
services:
- docker:dind
stages:
- kics
before_script:
- docker pull checkmarx/kics:$KICS_VERSION
kics:
stage: kics
script:
- >
docker run
-v $CI_PROJECT_DIR:/code
checkmarx/kics:$KICS_VERSION
scan
-p /code
For example for Azure Dev Ops Pipelines: trigger:
- main
variables:
- group: CxVariables
pool:
vmImage: 'ubuntu-latest'
steps:
- script: |
docker run \
-v $(Build.Repository.LocalPath):/code \
checkmarx/kics:$(KICS_VERSION) \
scan \
-p /code
displayName: 'KICS Scan' For example for Bitbucket Pipelines: image:
name: atlassian/default-image:2
pipelines:
default:
- step:
name: KICS Scan
script:
- docker run
-v $BITBUCKET_CLONE_DIR:/code
checkmarx/kics:$KICS_VERSION
scan
-p /code
services:
- docker |
Also it is required to have a README.md explaining which variables you need to define and which are default variables already defined on the pipeline for example:
For Azure example:
For Bitbucket Pipelines example:
|
@miguelfreitas93 I was about to file the same FR but is it necessary to run docker pull & docker run? I believe this would work instead: image: |
Yeah, that might work @jbrotsos for some build servers |
@miguelfreitas93 @jbrotsos your feedback is greatly appreciated. We'll take a look at those improvements. But then again, you're also welcome to contribute. We want to promote community engagement! ✌🏻 |
It's good to provide the option for our users to use docker in their CI/CD pipelines. We already have integration examples using docker for:
Currently, those are WIP:
TBD in the near future:
|
@rogeriopeixotocx are you still accepting community contribution for an updated template for Gitlab CI using the docker images? |
Hi @roock, yes we are :) |
This has already been implemented and can be closed |
Thank you @roock ! |
Expected Behavior
Have CI examples using docker instead of using complicated downloads on this folder https://github.com/Checkmarx/kics/tree/master/examples
Actual Behavior
Examples presented using wget, not docker
Specifications
The text was updated successfully, but these errors were encountered: