Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DEQ layer #5

Closed
rkurchin opened this issue Aug 24, 2020 · 4 comments · Fixed by #4
Closed

DEQ layer #5

rkurchin opened this issue Aug 24, 2020 · 4 comments · Fixed by #4
Labels
enhancement New feature or request

Comments

@rkurchin
Copy link
Member

Want to get this capability working (reference) eventually.

@rkurchin rkurchin added the enhancement New feature or request label Aug 24, 2020
@rkurchin rkurchin linked a pull request Aug 24, 2020 that will close this issue
@rkurchin
Copy link
Member Author

Food for thought: may need to be careful and do some preprocessing/rounding on weight matrices here, because sometimes graph edge weights that should be identical aren't quite...take the methane molecule for instance:

julia> Matrix(ag2.graph.weights)
5×5 Array{Float32,2}:
 0.0       0.999988  0.99999   1.0       0.999998
 0.999988  0.0       0.375009  0.374997  0.374993
 0.99999   0.375009  0.0       0.374993  0.374997
 1.0       0.374997  0.374993  0.0       0.374997
 0.999998  0.374993  0.374997  0.374997  0.0

And obviously a SteadyStateSolution would be a lot more sensitive to this than the result of just a couple discrete convolutions...

@rkurchin
Copy link
Member Author

@ChrisRackauckas @YingboMa any updates on whatever's needed under the hood (something with SteadyStateAdjoint I think?) for this to work? I just rebased the branch so all the syntax, etc. is up to date for the stuff that got renamed. deq.jl on the deq branch now runs up through building the model, but the forward pass just hangs forever and so obviously we can't train either.

@ChrisRackauckas
Copy link
Contributor

I don't think it's the implementation I think it's the method. A different rootfinding method would be needed her for a faster forward pass. The Newton iterations are just unstable so it needs to somehow be stabilized.

@rkurchin
Copy link
Member Author

Are you saying a new method needs to be implemented or just that I should try other methods?

Also, IIRC even when the forward pass worked, the backwards still didn't.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants