Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make a validate_features function #88

Open
rkurchin opened this issue Jun 23, 2021 · 0 comments
Open

make a validate_features function #88

rkurchin opened this issue Jun 23, 2021 · 0 comments

Comments

@rkurchin
Copy link
Member

Copying over from #85 ...

I had to comment out some checks in the main AtomGraph constructor that were validating that the encoded features actually matched the featurization (because it now dispatches on AbstractFeaturization rather than GraphNodeFeaturization specifically), so we could just make a new function like validate_features(encoded, fzn) that would dispatch across different featurization types, and if you fed in a DummyFeaturization it would always say it was okay.

The abstract dispatch is actually already there in #87 so "all" that remains is actual implementations (envisionable, though certainly not entirely trivial).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant