Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug] get_response_for_request raises TypeError if the request times-out #10288

Closed
paninaro opened this issue Feb 17, 2022 · 1 comment
Closed

[Bug] get_response_for_request raises TypeError if the request times-out #10288

paninaro opened this issue Feb 17, 2022 · 1 comment
Assignees
@paninaro
Labels
bug Something isn't working

Comments

@paninaro
Copy link
Contributor

What happened?

In keyring_proxy.py, get_response_for_request() will raise a TypeError exception when attempting to dereference response if the request made by _get() times-out.

Requests that time-out should raise a TimeoutError.

Version

1.3 beta

What platform are you using?

macOS

What ui mode are you using?

GUI

Relevant log output

No response
@paninaro paninaro added the bug Something isn't working label Feb 17, 2022
@paninaro paninaro self-assigned this Feb 17, 2022
@paninaro paninaro mentioned this issue Feb 17, 2022
Merged
@emlowe
Copy link
Contributor

emlowe commented Feb 8, 2024

Closing, this seems complete now by my reading

@emlowe emlowe closed this as completed Feb 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@paninaro paninaro

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@paninaro @emlowe