Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

can you enable some simple tests for components? #59

Open
atherdon opened this issue Jun 13, 2018 · 4 comments
Open

can you enable some simple tests for components? #59

atherdon opened this issue Jun 13, 2018 · 4 comments
Assignees

Comments

@atherdon
Copy link
Collaborator

not just if it renders, for sure.
for example selects should have data inside, etc.

@chauhannishith
Copy link
Contributor

one question
is the Recipe name going to be included in this component? Because a person searching for a recipe by name should not select any ingredients(i think so)

@atherdon
Copy link
Collaborator Author

not agree, because sometimes, you want to prepare a meal, but don't have some items in your pantry, or other cases. for now let's keep recipe name in this form. but please create a separated task for a future. where we'll discuss our next iterations of this project

@chauhannishith
Copy link
Contributor

because sometimes

i am talking about this sometimes
as not everytime someone will select a field and it can be empty and we can send null

@atherdon
Copy link
Collaborator Author

if people wouldn't fill recipe title - we just didn't send this field - that it.

later i plan to convert this form into a wizard, like yummly has, but for not it's not in priority

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants