Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed Playground Options Path Logic #984

Merged
merged 20 commits into from
Aug 9, 2019
Merged

Fixed Playground Options Path Logic #984

merged 20 commits into from
Aug 9, 2019

Conversation

michaelstaib
Copy link
Member

@michaelstaib michaelstaib commented Aug 9, 2019 •
edited
Loading

Fixes #877

@michaelstaib michaelstaib mentioned this pull request Aug 9, 2019
Closed
@michaelstaib michaelstaib self-assigned this Aug 9, 2019
@michaelstaib michaelstaib added this to the 10.0.0 milestone Aug 9, 2019
@michaelstaib
Copy link
Member Author

michaelstaib commented Aug 9, 2019 •
edited
Loading

The options classes are now inheriting from a GraphiQLOptionsBase ... this removes the code duplication.

In V11 we should probably introduce a AspNetCore.UI.Abstractions in order to remove the dependency to the HC core for the GraphiQL implementations.

@michaelstaib michaelstaib merged commit 1820eba into master Aug 9, 2019
@michaelstaib michaelstaib deleted the playground branch August 9, 2019 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@michaelstaib michaelstaib

Labels
None yet
Projects
None yet
Milestone
10.0.0
Development

Successfully merging this pull request may close these issues.

Playground not working if GraphQL path is set
1 participant
@michaelstaib