From 8a12d5cde4bc37b5a4fa82985aecc439dcda2921 Mon Sep 17 00:00:00 2001 From: Xon <635541+Xon@users.noreply.github.com> Date: Thu, 5 Sep 2024 10:59:51 +0800 Subject: [PATCH] Fix opt-group e2e tests false positive --- test-e2e/tests/select-multiple.spec.ts | 7 ++++--- test-e2e/tests/select-one.spec.ts | 7 ++++--- 2 files changed, 8 insertions(+), 6 deletions(-) diff --git a/test-e2e/tests/select-multiple.spec.ts b/test-e2e/tests/select-multiple.spec.ts index a69bdaa7..498eaba4 100644 --- a/test-e2e/tests/select-multiple.spec.ts +++ b/test-e2e/tests/select-multiple.spec.ts @@ -683,9 +683,10 @@ describe(`Choices - select multiple`, () => { await suite.startWithClick(); await expect(suite.dropdown.locator('.choices__group[data-group]')).toHaveCount(1); - expect( - await suite.selectableChoices.filter({ hasNot: page.locator('[data-group-id]') }).count(), - ).toBeGreaterThan(0); + expect(await suite.dropdown.locator('.choices__item--choice[data-group-id]').count()).toEqual(1); + expect(await suite.dropdown.locator('.choices__item--choice:not([data-group-id])').count()).toBeGreaterThan( + 1, + ); }); }); }); diff --git a/test-e2e/tests/select-one.spec.ts b/test-e2e/tests/select-one.spec.ts index 546164e6..2f2ffaf3 100644 --- a/test-e2e/tests/select-one.spec.ts +++ b/test-e2e/tests/select-one.spec.ts @@ -528,9 +528,10 @@ describe(`Choices - select one`, () => { await suite.startWithClick(); await expect(suite.dropdown.locator('.choices__group[data-group]')).toHaveCount(1); - expect( - await suite.selectableChoices.filter({ hasNot: page.locator('[data-group-id]') }).count(), - ).toBeGreaterThan(0); + expect(await suite.dropdown.locator('.choices__item--choice[data-group-id]').count()).toEqual(1); + expect(await suite.dropdown.locator('.choices__item--choice:not([data-group-id])').count()).toBeGreaterThan( + 1, + ); }); }); });