-
Notifications
You must be signed in to change notification settings - Fork 100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add mypy type annotations to BAC0 #324
Comments
I'm not against... there will be some challenges but why not... |
Ok cool. Definitely won't be 100% coverage and I won't add any coverage-based checks to the workflows. I'm hoping to get a chance to work on this in the next couple weeks... |
This issue had no activity for a long period of time. If this issue is still required, please update the status or else, it will be closed. Please note that an issue can be reopened if required. |
Finally got started on this last week! Made some good progress but still need to figure out how best to collect types for the TaskManager threads (since monkey type only runs in the parent process) |
This issue had no activity for a long period of time. If this issue is still required, please update the status or else, it will be closed. Please note that an issue can be reopened if required. |
BAC0 doesn't currently have many type annotations in place, I'd like to take a quick first pass at generating and adding them so that it's easier to work with the codebase.
I've previously had good luck with https://github.com/Instagram/MonkeyType and then manually editing its results where necessary.
I'd also like to add
mypy
to the github test workflows, so we can prevent regressions once the annotations are in place.This is a larger change so wanted to start a discussion before writing a whole mess of code - what do you think?
The text was updated successfully, but these errors were encountered: