Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Local Review Doesn't Work #140

Open
KyleTryon opened this issue Apr 7, 2022 · 0 comments
Open

Local Review Doesn't Work #140

KyleTryon opened this issue Apr 7, 2022 · 0 comments
Labels
backlog Identified as a backlog item, often combined with low-priority and help-wanted labels bug Something isn't working

Comments

@KyleTryon
Copy link
Contributor

KyleTryon commented Apr 7, 2022

Orb version:

11+

What happened:

Method 1:
circleci local execute --job orb-tools/review

Why this wont work:
The review job utilizes the save_test_results step which isnt supported locally and will cause the job to fail

Step failed
====>> Uploading test results
Archiving the following test results
  * /tmp/orb_dev_kit/review/review.xml

Error: Failed uploading test results
Error not supported

Method 2:
bats ./src/scripts/review.bats

Why this wont work:
The review.bats script is local to the orb-tools orb and will not be present in the local files of another orb without cloning it down first.

Expected behavior:

Ideally, it would be possible to run the circleci local execute job locally, though we would need a way to retrieve and then ideally view the JUNIT output.

Better output can be achieved locally by not exporting to JUNIT, but we would need the user to have bats installed and the review script locally.

Other:

CircleCI-Public/circleci-cli#684

@KyleTryon KyleTryon added the bug Something isn't working label Apr 7, 2022
@KyleTryon KyleTryon added the backlog Identified as a backlog item, often combined with low-priority and help-wanted labels label Oct 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backlog Identified as a backlog item, often combined with low-priority and help-wanted labels bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant