Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing data when transaction reverts in Web3.py breaks gas estimates #39

Open
adzialocha opened this issue Feb 19, 2021 · 1 comment
Open
Labels

Comments

@adzialocha
Copy link

adzialocha commented Feb 19, 2021

Estimating the gas fees of safe transactions fail in the relayer with the following error:

2021-02-19 14:29:20,922 [DEBUG] [MainProcess] Getting response HTTP. URI: https://dark-frosty-field.xdai.quiknode.pro/, Method: eth_call, Response: {'jsonrpc': '2.0', 'error': {'code': -32015, 'message': 'VM execution error.', 'data': 'Reverted 0x08c379a000000000000000000000000000000000000000000000000000000000000000200000000000000000000000000000000000000000000000000000000000000020000000000000000000000000000000000000000000000000000000000000d2fb'}, 'id': 509}
2021-02-19 14:29:20,922 [WARNING] [MainProcess] https://relay.circles.garden/api/v2/safes/0xe516F18f362Dd45892f2e32FC0643164F5179BD3/transactions/estimate/ - Exception: AttributeError: 'str' object has no attribute 'get' - Data received {'safe': '0xe516F18f362Dd45892f2e32FC0643164F5179BD3', 'data': '0xa2e62045', 'to': '0x75bb5e5029A752faeF0716929b7384D0bC78DE88', 'value': 0, 'operation': 0, 'gas_token': '0x0000000000000000000000000000000000000000'}

Please check related issue for more details: safe-global/safe-eth-py#26

@adzialocha adzialocha self-assigned this Feb 19, 2021
@adzialocha adzialocha changed the title Estimation of gas fees fails Estimation of gas fees fail Feb 19, 2021
@adzialocha
Copy link
Author

adzialocha commented Mar 18, 2021

This error propagated up to Web3.py ethereum/web3.py#1888 and got fixed with a temporary workaround in release 4.1.6.

Will still keep the ticket open for the future when the library issue has been resolved.

@adzialocha adzialocha changed the title Estimation of gas fees fail Missing data when transaction reverts in Web3.py breaks gas estimates Mar 18, 2021
@adzialocha adzialocha removed their assignment Apr 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant