Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

InvalidOwners in relayer-service logs #68

Open
JacqueGM opened this issue Dec 6, 2022 · 3 comments
Open

InvalidOwners in relayer-service logs #68

JacqueGM opened this issue Dec 6, 2022 · 3 comments
Assignees

Comments

@JacqueGM
Copy link

JacqueGM commented Dec 6, 2022

safe_relay_service.relay.services.transaction_service.InvalidOwners: ('Signers=%s are not valid owners of the safe. Owners=%s', ['0x4007cB2E9809C4c41621CAc496409867561DE978'], ['0xA62e6BF4d37970974b5AAeE2d29BB06dD94E7574'])

A bit of further investigation:

This line doesnt retrieve the signers property from the transaction

https://github.com/CirclesUBI/safe-relay-service/blob/main/safe_relay_service/relay/services/transaction_service.py#L604

In the

https://github.com/safe-global/safe-eth-py/blob/v4.5.1/gnosis/safe/safe_tx.py#L203

Why doesnt it read the existing signatures as the signers?

I suspect the problem is in this line... https://github.com/safe-global/safe-eth-py/blob/v4.5.1/gnosis/safe/safe_tx.py#L135 the signers = self.signers but there is not value - shouldn't it be signatures?

@JacqueGM JacqueGM self-assigned this Dec 6, 2022
@llunaCreixent
Copy link
Member

I've observed the InvalidOwners error when using the incorrect Safe version. We could test by trying to use the new core to execute a safe transaction (like a trust) from a Safe with the old version.

@JacqueGM
Copy link
Author

This seems to happen also a lot with fake accounts

@llunaCreixent
Copy link
Member

Fixed with CirclesUBI/circles-core#162
can you confirm, @JacqueGM and we close the issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants