Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update docker CI script to copy cloned yang models and generate fxs #46

Closed
ghost opened this issue Apr 23, 2016 · 2 comments
Closed

Update docker CI script to copy cloned yang models and generate fxs #46

ghost opened this issue Apr 23, 2016 · 2 comments
Assignees
Milestone

Comments

@ghost
Copy link

ghost commented Apr 23, 2016

Currently, the docker CI script uses pre-generated fxs files. However, the yang files should be used at build time to build fxs files. This will make sure if any changes are made to the test yang files, the changes are pulled in for each travis build

@ghost ghost added the enhancement label Apr 23, 2016
@ghost ghost added this to the 0.4.1 milestone Apr 23, 2016
@ghost
Copy link
Author

ghost commented Apr 25, 2016

On second thought, the meat of the bash script should probably reside on github and be passed to the docker .sh script as an argument. This would make it easier to edit and maintain

@psykokwak4
Copy link
Contributor

Agreed, we need to generate fxs files at run time, and passing the test script to docker container

@ghost ghost assigned psykokwak4 Apr 25, 2016
@ghost ghost closed this as completed Apr 26, 2016
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant