Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Three-way incompatibility makes /gs hand command error out (GrS + DummyCore + VintageFix) #213

Open
Wizzerinus opened this issue Aug 2, 2024 · 4 comments
Labels
bug Something isn't working

Comments

@Wizzerinus
Copy link
Contributor

After a hour of trial and error, I've reduced the set of required mods to the following:

Mixin Booter 9.1
GroovyScript 1.1.2
Dummy Core Unofficial 2.4.112.5
Vintage Fix 0.5.0
---
Universal Tweaks 1.11.0 (optional, triggers without it)
ConfigAnytime 3.0 (if UT is installed)

With these mods installed, attempting to /gs hand any item (I tried with oak leaves) triggers an error and the client says "Unknown error when executing the command":

java.lang.ClassCastException: net.minecraft.creativetab.CreativeTabs$2 cannot be cast to com.cleanroommc.groovyscript.core.mixin.CreativeTabsAccessor
	at com.cleanroommc.groovyscript.helper.ingredient.GroovyScriptCodeConverter.asGroovyCode(GroovyScriptCodeConverter.java:162) ~[GroovyScriptCodeConverter.class:?]
	at com.cleanroommc.groovyscript.compat.vanilla.command.infoparser.InfoParserCreativeTab.text(InfoParserCreativeTab.java:24) ~[InfoParserCreativeTab.class:?]
	at com.cleanroommc.groovyscript.compat.vanilla.command.infoparser.InfoParserCreativeTab.text(InfoParserCreativeTab.java:8) ~[InfoParserCreativeTab.class:?]
	at com.cleanroommc.groovyscript.compat.vanilla.command.infoparser.GenericInfoParser.copyText(GenericInfoParser.java:119) ~[GenericInfoParser.class:?]
	at com.cleanroommc.groovyscript.compat.vanilla.command.infoparser.GenericInfoParser.information(GenericInfoParser.java:143) ~[GenericInfoParser.class:?]
	at com.cleanroommc.groovyscript.compat.vanilla.command.infoparser.GenericInfoParser.iterate(GenericInfoParser.java:154) ~[GenericInfoParser.class:?]
	at com.cleanroommc.groovyscript.compat.vanilla.command.infoparser.GenericInfoParser.add(GenericInfoParser.java:168) ~[GenericInfoParser.class:?]
	at com.cleanroommc.groovyscript.compat.vanilla.command.infoparser.GenericInfoParser.add(GenericInfoParser.java:177) ~[GenericInfoParser.class:?]
	at com.cleanroommc.groovyscript.compat.vanilla.command.infoparser.InfoParserCreativeTab.parse(InfoParserCreativeTab.java:32) ~[InfoParserCreativeTab.class:?]
	at com.cleanroommc.groovyscript.compat.vanilla.command.infoparser.GenericInfoParser.parse(GenericInfoParser.java:213) ~[GenericInfoParser.class:?]
	at com.cleanroommc.groovyscript.api.infocommand.InfoParserPackage.lambda$parse$0(InfoParserPackage.java:178) ~[InfoParserPackage.class:?]
	at java.util.ArrayList.forEach(ArrayList.java:1259) ~[?:1.8.0_412]
	at com.cleanroommc.groovyscript.api.infocommand.InfoParserPackage.parse(InfoParserPackage.java:178) ~[InfoParserPackage.class:?]
	at com.cleanroommc.groovyscript.command.BaseInfoCommand.func_184881_a(BaseInfoCommand.java:145) ~[BaseInfoCommand.class:?]
	at net.minecraftforge.server.command.CommandTreeBase.func_184881_a(CommandTreeBase.java:164) ~[CommandTreeBase.class:?]
	at net.minecraft.command.CommandHandler.func_175786_a(CommandHandler.java:119) [bj.class:?]
	at net.minecraft.command.CommandHandler.func_71556_a(CommandHandler.java:91) [bj.class:?]
	at net.minecraft.network.NetHandlerPlayServer.func_147361_d(NetHandlerPlayServer.java:962) [pa.class:?]
	at net.minecraft.network.NetHandlerPlayServer.func_147354_a(NetHandlerPlayServer.java:941) [pa.class:?]
	at net.minecraft.network.play.client.CPacketChatMessage.func_148833_a(SourceFile:37) [la.class:?]
	at net.minecraft.network.play.client.CPacketChatMessage.func_148833_a(SourceFile:9) [la.class:?]
	at net.minecraft.network.PacketThreadUtil$1.run(SourceFile:13) [hv$1.class:?]
	at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511) [?:1.8.0_412]
	at java.util.concurrent.FutureTask.run(FutureTask.java:266) [?:1.8.0_412]
	at net.minecraft.util.Util.func_181617_a(SourceFile:46) [h.class:?]
	at net.minecraft.server.MinecraftServer.func_71190_q(MinecraftServer.java:723) [MinecraftServer.class:?]
	at net.minecraft.server.MinecraftServer.func_71217_p(MinecraftServer.java:668) [MinecraftServer.class:?]
	at net.minecraft.server.integrated.IntegratedServer.func_71217_p(IntegratedServer.java:185) [chd.class:?]
	at net.minecraft.server.MinecraftServer.run(MinecraftServer.java:1817) [MinecraftServer.class:?]
	at java.lang.Thread.run(Thread.java:750) [?:1.8.0_412]
@brachy84
Copy link
Member

Can not reproduce

@Wizzerinus
Copy link
Contributor Author

Will re-test this the next week

@Wizzerinus
Copy link
Contributor Author

Wizzerinus commented Aug 26, 2024

Reproduced with a clean Forge 2860 install with updated mod versions (used /gs looking):

MixinBooter 9.3
GroovyScript 1.1.3
VintageFix 0.5.1
Dummy Core Unofficial 2.4.112.5

No config changes or anything as that's a clean install. Also reproduced with Forge 2847 as I believe that's what dev env uses, just in case.

@WaitingIdly WaitingIdly added the bug Something isn't working label Aug 30, 2024
@Wizzerinus
Copy link
Contributor Author

Note: dev env doesn't reproduce this, even with the jars being put into the folder rather than using Maven dependencies.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants