Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ClemBot.Site dashboard layout sidebar doesnt work on mobile correctly #515

Open
Jay-Madden opened this issue Dec 29, 2021 · 14 comments
Open
Labels
ClemBot.Site Issue pertaincs to the ClemBot.Site codebase enhancement New feature or request help wanted Extra attention is needed

Comments

@Jay-Madden
Copy link
Member

We should have it be a flyout menu leveraging buefy and bulmas mobile css class options

@Jay-Madden Jay-Madden added enhancement New feature or request help wanted Extra attention is needed ClemBot.Site Issue pertaincs to the ClemBot.Site codebase labels Dec 29, 2021
@Jay-Madden
Copy link
Member Author

Cc @MayorMonty

@MatteuSan
Copy link

Can I take this issue?

@MatteuSan
Copy link

Also do you mind if I take on the design inconsistency fixes too?

@Jay-Madden
Copy link
Member Author

im certainly not opposed to it, what design inconsistencies are you seeing?

@MatteuSan
Copy link

well the card sizes and layout in the landing page is one. i’ll try to compile a list of what needs fixing tomorrow morning (with photos)

@Jay-Madden
Copy link
Member Author

For sure, css/html is not what I'm good at and it's fairly hacked together

@MatteuSan
Copy link

Do you mind if I take more time doing this issue? I lowkey need to rewrite the components from scratch instead of just using bulma. I need more control over the styles and how the HTML is structured so...

Also as promised, here's a few screenshots of what I've fixed so far. (dont worry about the home button, it's temporary. i just need to fix the logo being there)

image
image

@MatteuSan
Copy link

In comparison to what's in the prod version
image

@MatteuSan
Copy link

The sponsor card is inconsistent from the other cards too.

image

@MatteuSan
Copy link

  • Footer is somewhat... eh....

image

@MatteuSan
Copy link

Colors are somewhat all over the place too
The typography system is somewhat inconsistent
The border radius values as well

@MatteuSan
Copy link

For reference, here's a complete CSS audit: https://cssstats.com/stats/?url=https%3A%2F%2Fclembot.io%2F

@MatteuSan
Copy link

So those are the things that needs fixing/changing

@Jay-Madden
Copy link
Member Author

Jay-Madden commented Jan 4, 2022

Ohh wow those screenshots look good. I really like the border emboss and shadow a lot. However this many changes do need some more in depth discussion for sure. Join our discord here and ping me in the #clem-bot-discussion channel. https://discord.gg/wewgg4RQKw

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ClemBot.Site Issue pertaincs to the ClemBot.Site codebase enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants