Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot insert solid fuel into bionic fuel containers (affects mods) #62617

Closed
AmarinReyny opened this issue Dec 7, 2022 · 3 comments
Closed
Labels
(S1 - Need confirmation) Report waiting on confirmation of reproducibility stale Closed for lack of activity, but still valid.

Comments

@AmarinReyny
Copy link

AmarinReyny commented Dec 7, 2022

Describe the bug

So, as described here, there are some issues with the way solid fuel is handled by bionic fuel containers - specifically, there is no way to insert solid fuel into said containers. They can't be reloaded, trying to insert the fuel from the inventory menu doesn't work, etc..

Steps to reproduce

  1. Use a mod that adds a bionic that turns solid fuels into electricity
  2. Try to load said fuel into the bionic's fuel container
  3. Witness that you cannot

Expected behavior

I expect fuel containers to work just as well with solid fuels as they do with liquid fuels and batteries.

Screenshots

No response

Versions and configuration

  • OS: Windows
    • OS Version: MINGW/CYGWIN/MSYS2 on unknown Windows version
  • Game Version: fbfd667 [64-bit]
  • Graphics Version: Tiles
  • Game Language: System language []
  • Mods loaded: [
    Dark Days Ahead [dda],
    Disable NPC Needs [no_npc_food],
    No Fungal Growth [no_fungal_growth],
    Bionic Professions [package_bionic_professions],
    C.R.I.T Expansion Mod [crt_expansion],
    <color_light_blue>BL9-100%-monster-resilience-version [BL9_100monres],
    <color_light_red>Secronom [secronom],
    <color_light_red>Secronom+ Lore Expansion [secronom_lore_expansion],
    Aftershock [aftershock],
    Arcana and Magic Items [Arcana],
    Blaze Industries [blazeindustries],
    Magiclysm [magiclysm],
    Xedra Evolved [xedra_evolved],
    DinoMod [DinoMod],
    Arcana/Aftershock Patchmod [Arcana_aftershock_Patch],
    Arcana/DinoMod Patchmod [Arcana_Dinomod_Patch],
    Arcana/Magiclysm Patchmod [Arcana_Magiclysm_Patch],
    Extra Mutated Scenarios [extra_mut_scens],
    Mythical Martial Arts [MMA],
    Translate Complex Dialogue [translate_dialogue],
    Magiclysm No Class Limit [magiclysm_no_class_limit],
    SpeedyDex [speedydex],
    Stats Through Kills [stats_through_kills],
    Stats Through Skills [StatsThroughSkills],
    Tamable Wildlife [Tamable_Wildlife],
    Useful Helicopters Experimental [useful_helicopters],
    Arcadia Mapgen [custom_arcadia_mapgen],
    Cooler Versatility [coolervers],
    Custom Bionics [custom_bionics],
    XEAS [XEAS],
    return_the_nut [return_the_nut],
    consume_the_nut [consume_the_nut],
    Reproduction mod [perverts],
    Magiclysm Runes in Arcana Recipes [Custom_ArcanaRune]
    ]

Additional context

I know that I'm experiencing this problem with content from a non-mainlined mod, but given that we've tried making the mod work on that end, and ended up realizing that A. we can't make it work even with making sure that the bionics'/containers' code matches up perfectly with their vanilla counterparts, B. there otherwise is no indication that the problem comes from the mod itself, we think it's pretty safe to say that there's something wrong with the way the game handles solid bionic fuel. This would also mean that this problem will effect not just Arcana, but any mod, or even future vanilla content, that adds in bionics/containers meant to use solid fuels.

EDIT: Just to be clear, the bionic fuel containers are coded in a way that matches the way bionics now work in vanilla to a t. They still don't work.

@AmarinReyny AmarinReyny added the (S1 - Need confirmation) Report waiting on confirmation of reproducibility label Dec 7, 2022
@Hirmuolio
Copy link
Contributor

Hirmuolio commented Dec 7, 2022

I found the problem. There is weird check in reloading code that allows reloading CONTAINER type pockets only with liquids.
This is most likely to make it more convenient to reload bottles with drinks.

You can use the insert method instead. Look at the fuel tank and select (i)insert item. There you can put the essence in.
Maybe best would be to turn essence into ammo type and the fuel storage pocket into magazine so they can be easily reloaded.

If you still don't get any energy you may also need to disable fuel saving mode. Single charge of essence has 1200 kJ of energy and fuel saving mode will try to not waste it.

@AmarinReyny
Copy link
Author

AmarinReyny commented Dec 7, 2022

You can use the insert method instead. Look at the fuel tank and select (i)insert item. There you can put the essence in.

Already tried the insert method. It didn't work.

You may also need to disable fuel saving mode. Single charge of essence has 1200 kJ of energy and fuel saving mode will try to not waste it.

That'd be something to worry about if and when we finally manage to get any essence into the fuel tank.

@github-actions
Copy link
Contributor

github-actions bot commented Jan 7, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. Please do not bump or comment on this issue unless you are actively working on it. Stale issues, and stale issues that are closed are still considered.

@github-actions github-actions bot added the stale Closed for lack of activity, but still valid. label Jan 7, 2023
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Feb 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
(S1 - Need confirmation) Report waiting on confirmation of reproducibility stale Closed for lack of activity, but still valid.
Projects
None yet
Development

No branches or pull requests

2 participants