Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crash because body part definition's limb_type, "limb_types" are not copied with "copy-from" #76686

Closed
Psithief opened this issue Sep 27, 2024 · 1 comment
Labels
(S1 - Need confirmation) Report waiting on confirmation of reproducibility

Comments

@Psithief
Copy link
Contributor

Psithief commented Sep 27, 2024

Describe the bug

When creating a body part and using copy-from, if the limb_types and limb_type properties are omitted from the copy, the game will crash when looking at the medical screen.

Attach save file

N/A, requires editing a file, see below.

Steps to reproduce

  1. Edit data/mods/Xedra_Evolved/body_parts.json and remove the property "limb_type" from "karma_arm_up_l"
  2. Create a world with Xedra Evolved.
  3. Create a character.
  4. Grant the character the Karma Arms spell.
  5. Cast the spell.
  6. Open the medical screen, get a game crash

Character::disp_medical … Character::get_limb_score … Character::manipulator_score … std::_Xout_of_range

Expected behavior

  1. If neither limb_types or limb_type is found for a body part, abort loading the game.
  2. Copy the properties from limb_type and limb_types when using copy-from as expected.

Screenshots

No response

Versions and configuration

  • OS: Windows
    • OS Version: 10-ish
  • Game Version: 4254b22 [64-bit]
  • Graphics Version: Tiles
  • Game Language: System language []
  • Mods loaded: [
    Dark Days Ahead [dda],
    Disable NPC Needs [no_npc_food],
    Portal Storms Ignore NPCs [personal_portal_storms],
    Slowdown Fungal Growth [no_fungal_growth],
    Xedra Evolved [xedra_evolved],
    No Monsters [Only_Wildlife]
    ]

Additional context

No response

@Psithief Psithief added the (S1 - Need confirmation) Report waiting on confirmation of reproducibility label Sep 27, 2024
@Psithief
Copy link
Contributor Author

Psithief commented Oct 8, 2024

Duplicate of #72044

@Psithief Psithief closed this as not planned Won't fix, can't repro, duplicate, stale Oct 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
(S1 - Need confirmation) Report waiting on confirmation of reproducibility
Projects
None yet
Development

No branches or pull requests

1 participant