Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide test/tool for finding redundant coordinate type conversions #76738

Open
PatrikLundell opened this issue Sep 30, 2024 · 0 comments
Open
Labels
<Suggestion / Discussion> Talk it out before implementing

Comments

@PatrikLundell
Copy link
Contributor

Is your feature request related to a problem? Please describe.

We're in a very slow conversion process from using untyped coordinates to typed ones. As part of the process, we end up having to convert/specify the type of parameters to operations for two reasons:

  • The parameter passed is untyped, and thus has to be converted.
  • The operation is overloaded, so a coordinate set has to be specified to be either the typed or the untyped version.

What I'm after is a tool that allows us to find the cases where conversion/specification has been rendered redundant because the parameter passed has now been typed, as well as the cases where the untyped overload has been removed, and so there is no need to specify the type of the parameter.

Solution you would like.

Some kind of tool that identifies locations that ought to be simplified.

Describe alternatives you have considered.

Add it to the suite of mandatory code changes. It would probably be harmful, as there are probably a whole lot of these out there, and we'd need get rid of the backlog so all cases reported are newly produced. Also, I'm not sure adding additional rigidity to a system that's already extremely rigid is a good thing.

Additional context

No response

@PatrikLundell PatrikLundell added the <Suggestion / Discussion> Talk it out before implementing label Sep 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
<Suggestion / Discussion> Talk it out before implementing
Projects
None yet
Development

No branches or pull requests

1 participant