-
Notifications
You must be signed in to change notification settings - Fork 193
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Field
should subtype an array type for named axis behaviors?
#457
Comments
Could be interesting to explore! @suyashbire1 has looked at this I think The big concerns are obviously performance, GPU compatibility, and we probably don't want to depend on an immature or abandoned package. We depend heavily on OffsetArrays.jl but it doesn't really come with any features we use besides the array type itself. |
I am talking about changes to For the way we currently time-step this would also have no effect on GPU compatibility, because, again, we use |
Field
should subtype an array typed for named axis behaviors?Field
should subtype an array type for named axis behaviors?
I think we've somewhat converged on DimensionalData.jl but I will say I love how AxisKeys.jl looks! https://github.com/mcabbott/AxisKeys.jl |
I'm closing this issue because I'm judging that it's not of current, timely relevance to Oceananigans development. If you would like to make it a higher priority or if you think the issue was closed in error please feel free to re-open. |
Our
Field
type may benefit from subtyping one of the many array types with named/dimensional axes out there in the julia ecosystem. This will permit some desirable behaviors for the manipulation, loading, output, and plotting of fields and slices of fields, and perhaps will also enable some nice behavior for online diagnostics.A good option could be
AbstractDimensionalArray
defined byhttps://github.com/rafaqz/DimensionalData.jl
We'll have to figure out what functions and such we'd have to define to complete such an implementation.
The text was updated successfully, but these errors were encountered: