Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LES regression test #473

Closed
ali-ramadhan opened this issue Oct 13, 2019 · 1 comment · Fixed by #484
Closed

LES regression test #473

ali-ramadhan opened this issue Oct 13, 2019 · 1 comment · Fixed by #484
Labels
testing 🧪 Tests get priority in case of emergency evacuation

Comments

@ali-ramadhan
Copy link
Member

Seems like a good idea to have an LES regression test for big PRs that modify the TurbulenceClosures module such as PR #452.

I guess we can use a coarse stratified Couette flow or free convection simulation in steady state to check for this.
@ali-ramadhan ali-ramadhan added the testing 🧪 Tests get priority in case of emergency evacuation label Oct 13, 2019
@glwagner
Copy link
Member

The ocean_wind_mixing_and_convection.jl example uses an LES closure. I think just copy and pasting that into a regression script would work.

@glwagner glwagner mentioned this issue Oct 15, 2019
Closed
@ali-ramadhan ali-ramadhan mentioned this issue Oct 16, 2019
Merged
@glwagner glwagner mentioned this issue Oct 16, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
testing 🧪 Tests get priority in case of emergency evacuation
Projects
None yet
Milestone
No milestone
2 participants
@glwagner @ali-ramadhan