Logical error in function greatest

[alexey-milovidov]

Describe the bug

SELECT * FROM system.data_skipping_indices WHERE (table = 'alter_index_test') AND greatest(greatest(NULL, NULL, greatest(greatest(greatest(-2), '9223372036854775806', sleep(1), NULL), NULL), '102.5', NULL), greatest('-9223372036854775808', NULL), greatest(greatest(NULL), NULL, '0.0000065536', NULL)) AND (database = currentDatabase())

Cannot capture 4 columns because function greatest has 0 arguments.: while executing 'FUNCTION greatest(greatest(-2) :: 8, '9223372036854775806' :: 9, sleep(1) :: 6, NULL : 7) -> greatest(greatest(-2), '9223372036854775806', sleep(1), NULL) Nullable(Nothing) : 14'. (LOGICAL_ERROR)

How to reproduce
Always reproduced.

[alexey-milovidov]

It is reproduced if short circuit evaluation is enabled:

SELECT 1 AND greatest(sleep(0))

[Avogar]

The bug is in LeastGreatestOverloadResolver, it passes empty list of argument types to FunctionToFunctionBaseAdaptor:

ClickHouse/src/Functions/LeastGreatestGeneric.h

Lines 109 to 116 in a6a19c6

	DataTypes argument_types;
	/// More efficient specialization for two numeric arguments.
	if (arguments.size() == 2 && isNumber(arguments[0].type) && isNumber(arguments[1].type))
	return std::make_unique<FunctionToFunctionBaseAdaptor>(SpecializedFunction::create(context), argument_types, return_type);
	return std::make_unique<FunctionToFunctionBaseAdaptor>(
	FunctionLeastGreatestGeneric<kind>::create(context), argument_types, return_type);

Will fix it.