Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve sockets housekeeping mechanism #237

Closed
slvrtrn opened this issue Mar 11, 2024 · 0 comments · Fixed by #242
Closed

Improve sockets housekeeping mechanism #237

slvrtrn opened this issue Mar 11, 2024 · 0 comments · Fixed by #242
Labels
enhancement New feature or request
Milestone
1.0.0

Comments

@slvrtrn
Copy link
Contributor

slvrtrn commented Mar 11, 2024

Currently, implemented in a branch: main...idle-sockets-timeouts

It needs a rebase to 1.0.0.

General idea: instead of tracking if a socket could be expired while idling and deciding what to do with it when making an HTTP request, just terminate it after (by default) 2500 ms using Node.js Socket.on('free') API.
@slvrtrn slvrtrn added the enhancement New feature or request label Mar 11, 2024
@slvrtrn slvrtrn added this to the 1.0.0 milestone Mar 11, 2024
This was referenced Mar 12, 2024
Merged
Merged
@slvrtrn slvrtrn mentioned this issue Mar 29, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
1.0.0
Development

Successfully merging a pull request may close this issue.

Node.js connection idle sockets timeout rework, logger improvements ClickHouse/clickhouse-js
1 participant
@slvrtrn