Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use of a shared bucket? #73

Open
LeoLapworthKT opened this issue Sep 21, 2023 · 1 comment
Open

Use of a shared bucket? #73

LeoLapworthKT opened this issue Sep 21, 2023 · 1 comment

Comments

@LeoLapworthKT
Copy link

We've started using this great module more and more across our stacks.

But we now have a dozen S3 buckets all with just 1 zip file in and as we intent to use it even more it made me wonder about if it could be made to use a shared bucket? It's not a blocker, but we had to ask for our S3 bucket quota to be raised which made me ponder this.

If we looked into submitting a patch would you be interested in this?

@kichik
Copy link
Member

kichik commented Sep 21, 2023

We've started using this great module more and more across our stacks.

Awesome 🙌

If we looked into submitting a patch would you be interested in this?

For sure. It was always a future thing. I didn't want to worry about possible zip conflicts on the first iteration. I think we can maybe completely prevent this with an object prefix based on the stack and resource name. Maybe even make that prefix be something the user can override.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants