Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Networks with spaces in the name cannot be specified #83

Open
benlangfeld opened this issue Nov 26, 2013 · 2 comments
Open

Networks with spaces in the name cannot be specified #83

benlangfeld opened this issue Nov 26, 2013 · 2 comments

Comments

@benlangfeld
Copy link
Contributor

Since networks are stored in stack definitions as a space/comma separated string, it's not possible to specify a network with a space in the name because this will be split into multiple entries. This data is coming from JSON, so why not use a JSON Array?

@sbotman
Copy link
Contributor

sbotman commented Nov 27, 2013

Well, I personally don't use the stack option that often. But this seems like a good idea to me! If you have time to change this, then please do. Otherwise I will look into this when time permits. In the meantime you might want to specify the network id's. These don't contain any spaces and should also work just fine.

@benlangfeld
Copy link
Contributor Author

I'll prep a PR in the near future which removes all string manipulation from JSON. For now I'll use the ID. Thanks :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants