Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve the [test_profile_respected] test to verify a given profiles list (instead of hardcoded profiles) #2956

Open
shay-berman opened this issue Nov 22, 2016 · 2 comments

Comments

@shay-berman
Copy link

shay-berman commented Nov 22, 2016

The functional test named [IBMStorageIProfiledBlockDeviceAPITestsMixin.test_profile_respected], is testing if the Flocker driver respect the hardcoded profile names : gold, silver and bronze.

But the IBM flocker driver(coming soon) supports other profile names.

So lets improve the test so it will get(parameter to the test) a list of available driver's profiles as a parameter to the test.

Thanks
Shay

@wallnerryan
Copy link
Contributor

thanks @shay-berman ! What do you think about contributing a patch to Flocker based on the work that you did? Would this be of interest? We would be happy to accept a contribution and give you and your work credit in our project.

cc @wallrj

@wallrj
Copy link
Contributor

wallrj commented Nov 25, 2016

Yep, I think this is a good idea.
There are already a bunch of environment variables that control whether and how the functional tests are run;

Or maybe we need to add a new overridable parameter to make_iprofiledblockdeviceapi_tests(profile_names=DefaultProfiles,...)

And change the name of MandatoryProfiles > DefaultProfiles.

Also update https://flocker-docs.clusterhq.com/en/latest/gettinginvolved/plugins/index.html to change our policy that says

Please note that you must implement bronze, silver and gold profiles.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants