Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Throws exception with Clara 0.18.0 #115

Open
SevereOverfl0w opened this issue May 17, 2018 · 2 comments
Open

Throws exception with Clara 0.18.0 #115

SevereOverfl0w opened this issue May 17, 2018 · 2 comments
Labels

Comments

@SevereOverfl0w
Copy link

deps.edn of:

{:deps {com.cerner/clara-rules {:mvn/version "0.18.0"}
        precept {:mvn/version "0.4.0-alpha"}}}

Running clj:

Clojure 1.9.0
user=> (require 'precept.listeners)
WARNING: qualified-keyword? already refers to: #'clojure.core/qualified-keyword? in namespace: clara.rules.dsl, being replaced by: #'clara.rules.dsl/qualified-keyword?
CompilerException java.lang.IllegalArgumentException: Can't define method not in interfaces: insert_facts_BANG_, compiling:(precept/listeners.cljc:14:1)
user=>
@alex-dixon alex-dixon added the bug label May 17, 2018
@WilliamParker
Copy link

This looks like the result of the breaking changes in oracle-samples/clara-rules#366 that @alex-dixon mentioned in #clara on Slack. The specific change line

@SevereOverfl0w if you want to try Precept with the newer Clara it should be sufficient to just uplift the Precept listeners in question to have the new arguments added, even if they're never used. The values of the existing argument "facts" shouldn't be changed from what it was before. The breakage is unfortunate, we (the Clara maintainers) thought the long-term cruft of trying to make it passive wouldn't be worth it for something that seems like a trivial uplift though.

@alex-dixon
Copy link
Contributor

alex-dixon commented May 21, 2018

@WilliamParker I guess I broke myself on that one. :) If someone wants to use Precept <= 0.5.0-alpha and Clara >= 0.17.0 they won't be able to. I'm definitely willing to accept that.

0.5.0-alpha is on the issue-19 branch and works with Clara 0.17.0.

Leaving this open to ensure the next release is also compatible with Clara 0.18.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants