Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

workspace.schemes doesn't load schemes in the workspace container #557

Closed
loufranco opened this issue Mar 21, 2018 · 4 comments
Closed

workspace.schemes doesn't load schemes in the workspace container #557

loufranco opened this issue Mar 21, 2018 · 4 comments

Comments

@loufranco
Copy link
Contributor

Here is a simple Xcode workspace with 2 projects and a scheme that is in the Workspace (not one of the projects)

WorkspaceSchemes.zip

I included an xc.rb to run

when you run it, it doesn't list WorkspaceSchemesScheme, which is here:

./WorkspaceSchemes.xcworkspace/xcshareddata/xcschemes/WorkspaceSchemesScheme.xcscheme

When you manage schemes you will see that this scheme is tied to the workspace, not a project.

fastlane has recently adopted xcodeproj and it uses workspace.schemes to get a list of schemes, which won't list this one. It now can't build workspaces like this.

@loufranco
Copy link
Contributor Author

I'd be happy to contribute a fix, but I would need some guidance on what you want.

If Workspace.load_schemes would load these, is it ok to map from the scheme name to the workspace filename.

Or, to maintain backwards compatibility (since that function says it loads project schemes), should you add Workspace.load_workspace_schemes to do that?

I'm ambivalent to the solution -- fastlane just uses the keys of this map, so whatever xcodeproj does is probably fine for them.

@endocrimes
Copy link
Member

@loufranco We should probably roll this into the load_schemes method imo

@loufranco
Copy link
Contributor Author

Ok, will post a PR soon

@foux
Copy link

foux commented Sep 7, 2018

Still the exact same problem in 1.6.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants