Xcode 10 changes for test schemes #583
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
June 27, 2018 15:05
added: * parallelization * randomized test order * whitelisted tests
segiddins
approved these changes
Jun 27, 2018
spec/scheme/test_action_spec.rb
Outdated
| @@ -221,6 +221,7 @@ module Xcodeproj | |||
| test_ref.xml_element.name.should == 'TestableReference' | |||
| test_ref.xml_element.attributes.count.should == 1 | |||
| test_ref.xml_element.attributes['skipped'].should == 'NO' | |||
| test_ref.randomized?.should.be.false? | |||
There was a problem hiding this comment.
test_ref.should.not.be.randomized
There was a problem hiding this comment.
did not know abt this syntax!
lib/xcodeproj/scheme/test_action.rb
Outdated
| # Set the list of SelectedTest this action will run. | ||
| # | ||
| def selected_tests=(tests) | ||
| @xml_element.delete_element('SelectedTests') unless @xml_element.elements['SelectedTests'].nil? |
There was a problem hiding this comment.
should be able to delete the conditional on this line -- calling delete with a parameter that's not in the collection will just return nil
There was a problem hiding this comment.
this is copied from skipped_tests= so i removed it there too
lib/xcodeproj/scheme/test_action.rb
Outdated
| # | ||
| def selected_tests=(tests) | ||
| @xml_element.delete_element('SelectedTests') unless @xml_element.elements['SelectedTests'].nil? | ||
| if tests.nil? |
spec/scheme/test_action_spec.rb
Outdated
| describe 'randomized' do | ||
| it '#randomized? detect a true value' do | ||
| @sut.xml_element.attributes['testExecutionOrdering'] = 'random' | ||
| @sut.randomized?.should == true |
spec/scheme/test_action_spec.rb
Outdated
|
|
||
| it '#randomized= set false value' do | ||
| @sut.randomized = false | ||
| @sut.xml_element.attributes['testExecutionOrdering'].should.nil? |
dnkoutso
approved these changes
Jun 28, 2018
|
fixed @segiddins's review in 0a2137e |
added 2 commits
June 28, 2018 10:40
|
🚢 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added: