Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Xcode 11 platformFilter isn't understood for PBXTargetDependency #693

Closed
lickel opened this issue Jul 8, 2019 · 3 comments
Closed

Xcode 11 platformFilter isn't understood for PBXTargetDependency #693

lickel opened this issue Jul 8, 2019 · 3 comments

Comments

@lickel
Copy link

lickel commented Jul 8, 2019

When Catalyst is enabled for an iOS app which has targets that are invalid on iOS, the target automatically gets a platformFilter.

This is not fixed by #687

[!] [!] Xcodeproj doesn't know about the following attributes {"platformFilter"=>"ios"} for the 'PBXTargetDependency' isa.

		329B71611D82926D00336078 /* PBXTargetDependency */ = {
			isa = PBXTargetDependency;
			platformFilter = ios;
			target = 329B71551D82926C00336078 /* NotificationContentReaction */;
			targetProxy = 329B71601D82926D00336078 /* PBXContainerItemProxy */;
		};
@dnkoutso
Copy link
Contributor

dnkoutso commented Jul 8, 2019 •
edited
Loading

@lickel thanks! We can open up a PR to fix this!

@dnkoutso dnkoutso mentioned this issue Jul 8, 2019
Merged
@dnkoutso dnkoutso closed this as completed Jul 8, 2019
@dnkoutso
Copy link
Contributor

dnkoutso commented Jul 8, 2019

PR was merged. Will ship with 1.11.0 of Xcodeproj. Use https://bundler.io/ to point to a specific SHA or branch that includes the fix.

@dnkoutso
Copy link
Contributor

dnkoutso commented Jul 9, 2019

Released with 1.11.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@lickel @dnkoutso