Glyphicons changed to Font Awesome #233
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 10 commits
February 28, 2018 10:47
edworczak
commented
Mar 2, 2018
| @@ -46,32 +46,7 @@ | |||
| <div ui-view="content"></div> | |||
| </div> | |||
|
|
|||
| <!-- | |||
| Comments modal | |||
| --> | |||
There was a problem hiding this comment.
That was the old popup to add a comment that was no longer needed.
szymon-owczarzak
approved these changes
Mar 5, 2018
jakublamprecht
requested changes
Mar 6, 2018
| @@ -92,8 +92,8 @@ define(['angularAMD'], function (angularAMD) { | |||
|
|
|||
| function updateFiltersLabel(activeFilters) { | |||
| var titleElement = $('.filter-list-title p '), | |||
| iconApply = $('.filter-list-title .glyphicon-chevron-down'), | |||
| iconCancel = $('.filter-list-title .glyphicon-remove'); | |||
| iconApply = $('.filter-list-title .apply-filters'), | |||
jakublamprecht
approved these changes
Mar 6, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
All Glyphicons are changed to Font Awesome.
Motivation and Context
Icons from Font Awesome are more flexible than Glyphicons, prettier and there are more of them.
I hereby agree to the terms of the AET Contributor License Agreement.