Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch off the default require.js timeout #239

Merged
merged 2 commits into from
Apr 17, 2018
Merged

Conversation

michaldziubek
Copy link
Contributor

Description

This change is switching off the default require.js timeout, to prevent report app from not loading while on slow network.

Motivation and Context

Currently, in most cases, the report app is not loading on slow networks due to timeout caused by require.js (Uncaught Error: Load timeout for modules: angularAMD,lodash,angular-bootstrap,angular-ui-router,jquery,bootstrap,scroller,angular). This change is switching off the default timeout, to prevent it from happening.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

I hereby agree to the terms of the AET Contributor License Agreement.

@wiiitek
Copy link
Contributor

wiiitek commented Apr 17, 2018

See also wttech/aet-cookbook#17

@wiiitek wiiitek merged commit 48445b3 into master Apr 17, 2018
@wiiitek wiiitek deleted the slow-network-app-timeout branch April 17, 2018 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants