Url routing expands current element #244
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
April 20, 2018 12:40
| $parentElement.click(); | ||
| performScroll($parentElement); | ||
| $reportGroup.addClass('is-expanded'); | ||
|
|
There was a problem hiding this comment.
Nope, missed that. Thanks!
mateuszluczak
approved these changes
Apr 20, 2018
zajcu
approved these changes
Apr 20, 2018
wiiitek
approved these changes
Apr 20, 2018
malaskowski
approved these changes
Apr 20, 2018
# Conflicts (resolved): # CHANGELOG.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a result of this change - side panel will be scrolled now to the element which is being navigated to via url.
Description
Whenever user navigates to report using url that leads to specific test/url, sidepanel will be scrolled to it's position.
Motivation and Context
Previously, user didn't know where the currently opened test/url is located on side panel and had to find it manually.
Screenshots (if appropriate):
Types of changes
Checklist:
I hereby agree to the terms of the AET Contributor License Agreement.