Bobcat upgrade #268
Merged
Bobcat upgrade #268
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
malaskowski
reviewed
Jun 29, 2018
| # +++ Chrome +++ | ||
| #webdriver.chrome.driver property should point to Chrome webdriver executable. | ||
| webdriver.type=chrome | ||
| webdriver.chrome.driver=D:/Selenium/chromedriver.exe |
There was a problem hiding this comment.
When this path is required. Will this work on all instances?
There was a problem hiding this comment.
You are right: this is an arbitrary value. If chromedriver is not found then there is a stacktrace with following error:
2) Error in custom provider, java.lang.IllegalStateException: The driver executable does not exist: D:\Selenium\chromedriver.exe
If this config value is commented then we have following error:
2) Error in custom provider, java.lang.IllegalStateException: The path to the driver executable must be set by the webdriver.chrome.driver system property;
What should we do here? Currently on master we have:
There was a problem hiding this comment.
Maybe we should at least document the necessary change on the path to the chromedriver in the comment on in the it-tests README ?
There was a problem hiding this comment.
I have update the README
# Conflicts (resolved): # CHANGELOG.md
malaskowski
approved these changes
Jul 2, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Upgrade to newest released version of Bobcat and dependencies clean-up.
Motivation and Context
We should review our functional tests and make them run faster. They might be more compact.
Types of changes
Checklist:
I hereby agree to the terms of the AET Contributor License Agreement.