Update osgi annotations in datastorage #316
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PiteroS678
changed the title
malaskowski
changed the base branch from
master
to
feature/upgrade-osgi-annotations
tkaik
reviewed
Aug 9, 2018
| + "...[,hostN[:portN]]][/[database][?options]]", type = AttributeType.STRING) | ||
| String MongoURI() default DEFAULT_MONGODB_URI; | ||
|
|
||
| @AttributeDefinition(name = ALLOW_AUTO_CREATE, description = "Allows automatic creation of DB if set to true", type = AttributeType.BOOLEAN) |
There was a problem hiding this comment.
name should be set to the label value of old annotation
malaskowski
suggested changes
Aug 10, 2018
| boolean DEFAULT_AUTOCREATE_VALUE = false; | ||
|
|
||
| @AttributeDefinition(name = MONGO_URI_PROPERTY_NAME, description = MONGO_URI_PROPERTY_DESCRIPTION, type = AttributeType.STRING) | ||
| String MongoURI() default DEFAULT_MONGODB_URI; |
There was a problem hiding this comment.
In Java usually methods names start with lowercase. Please adjust methods names in this interface.
There was a problem hiding this comment.
There's a problem with that adjustment. @AttributeDefinition is case sensitive to keys from *.cfg
https://github.com/Cognifide/aet/blob/master/osgi-dependencies/configs/src/main/resources/com.cognifide.aet.vs.mongodb.MongoDBClient.cfg#L19
There was a problem hiding this comment.
Darn...
Let's leave it as is for now. Could you please raise a new ticket to fix that (make the properties to start with lowercase) in the future?
Thanks
malaskowski
approved these changes
Aug 10, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I updated osgi annotations in datastorage
Motivation and Context
Before, annotations was marked as deprecated
Screenshots (if appropriate):
Types of changes
Checklist:
I hereby agree to the terms of the AET Contributor License Agreement.