Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support env variables in report manager #325

Merged
merged 8 commits into from
Aug 28, 2018

Conversation

malaskowski
Copy link
Contributor

Description

ReportConfigurationManager reportDomain is not modifiable outside OSGi scope. This is required to configure with Docker cluster managers.

Motivation and Context

Enable setting reportDomain as an environment variable. It will override any OSGi settings if provided.
This feature will be documented in the future in the Docker support section.
The priority of setting this value is:

  • OSGi configuration
  • env variable REPORT_DOMAIN
  • default configuration value

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

I hereby agree to the terms of the AET Contributor License Agreement.

@malaskowski malaskowski changed the base branch from milestone/chrome-support to master August 21, 2018 13:01
@malaskowski malaskowski changed the base branch from master to milestone/chrome-support August 21, 2018 13:01
@malaskowski malaskowski changed the base branch from milestone/chrome-support to master August 21, 2018 15:00
@malaskowski malaskowski merged commit 9610351 into master Aug 28, 2018
@malaskowski malaskowski deleted the feature/support-env-variables-in-report-manager branch August 28, 2018 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants