Rerun one test / Rerun suite #337

plutasnyy · 2018-08-28T13:16:14Z

We added ability to rerun one test or whole suite

Description

We created new endpoint /rerun-suite which get information about company, project and correlationId. With these parameters whole suite will be started. If you also provide testName, aet will create fake suite with one test and override result in database. Rerun option is avaible only for the latest suite.

Screenshots (if appropriate):

Types of changes

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

My code follows the code style of this project.
My change requires a change to the documentation.
I have updated the documentation accordingly.

I hereby agree to the terms of the AET Contributor License Agreement.

… feature/rerun

…s on update

… feature/rerun

plutasnyy · 2018-09-16T09:37:03Z

...communication-api/src/main/java/com/cognifide/aet/communication/api/metadata/Comparator.java

@@ -49,6 +49,9 @@ public void setStepResult(ComparatorStepResult stepResult) {
  }

  public List<Operation> getFilters() {
+    if(filters == null){
+      return new ArrayList<>();
+    }


It could be a little bit confusing why I compare filters with null, filters have initial value new ArrayList<> so they never are null, but if the array is empty, in the database we haven't got information about it, this field doesn't exist. It was the easiest way to solve NullPointerException, what do you think about saving filters:[] in the database when the array is empty? Or maybe you know another way to solve it?

This logic is managed by Suite.GSON_FOR_JSON Gson instance. It is used in toJson method. It has registered several adapters, one of them is to manage java Collection conversions. You may see the logic of dealing with null collections here:
https://github.com/Cognifide/aet/blob/master/api/communication-api/src/main/java/com/cognifide/aet/communication/api/metadata/gson/CollectionSerializer.java#L30

Let's just be sure that changing logic here won't break metadata documents saved before this change is introduced.

You can leave it as is, without refactoring GSON_FOR_JSON logic. But it should return Collections.emptyList() instead of new ArrayList<>().

plutasnyy · 2018-09-16T09:56:05Z

report/src/main/webapp/app/services/endpointConfiguration.service.js

+      },
+      getDomain: function () {
+        var config = {
+          'getUrl': domain
        };


This change is a result of change suitestatus to api/suitestatus. After that servlet returns api/.., and after concatenation I will have /api/api/suitestatus -> incorrect URL. I can escape api from one of this URL, but I guess it isn't good practice. In additional I didn't want to manipulate URL returned by the servlet, it could be problematic for the client and create more problems for this easy case so I decided to add the new function with a used domain from a variable. Is it a good way? Will it require from users some changes in their configs?

Please look at my review comment. This can't be programmed like now.

malaskowski · 2018-09-24T09:41:55Z

...ommunication-api/src/main/java/com/cognifide/aet/communication/api/messages/ProgressLog.java

-public class ProgressLog {
+import java.io.Serializable;
+
+public class ProgressLog implements Serializable {


Please add serialVersionUID to this and all Serializable classes.

malaskowski · 2018-09-24T09:43:21Z

...communication-api/src/main/java/com/cognifide/aet/communication/api/metadata/Comparator.java

@@ -49,6 +49,9 @@ public void setStepResult(ComparatorStepResult stepResult) {
  }

  public List<Operation> getFilters() {
+    if(filters == null){
+      return new ArrayList<>();
+    }


You can leave it as is, without refactoring GSON_FOR_JSON logic. But it should return Collections.emptyList() instead of new ArrayList<>().

malaskowski · 2018-09-24T09:54:20Z

.../runner/src/main/java/com/cognifide/aet/runner/processing/data/wrappers/RunIndexWrapper.java

+import java.util.List;
+import java.util.Optional;
+
+public abstract class RunIndexWrapper {


com.cognifide.aet.communication.api.wrappers.Run is a parameterized class. Shouldn't template information be also kept in this class?
I mean

public abstract class RunIndexWrapper<T> { protected Run<T> objectToRunWrapper = null; ...

malaskowski · 2018-09-24T09:58:18Z

core/runner/src/main/java/com/cognifide/aet/runner/processing/steps/CollectDispatcher.java

+          urlRunWrapper.getProxy(), urlRunWrapper.getPreferredBrowserId());
+      ObjectMessage message = session.createObjectMessage(data);
+      message.setJMSCorrelationID(correlationId);
+      messagesQueue.add(new MessageWithDestination(getQueueOut(), message, 1));


Could you please create an issue with technical debt label about refactoring MessageWithDestination to hold always only one message?

malaskowski · 2018-09-24T10:01:07Z

documentation/src/main/wiki/TestExecutor.md

+
+###### Request
+
+* **URL**: `/suite-rerun`


It is /api/suite-rerun now.

malaskowski · 2018-09-24T10:02:38Z

documentation/src/main/wiki/TestExecutor.md

+* **URL**: `/suite-rerun`
+* **HTTP Method**: POST
+* **Parameters**:
+    * `correlationId` - Correlation ID of the suite to rerun, used to get it from the database


Would it be possible to also support company, project, suite, version?
Does that make sense?
It could be done as an improvement in separate PR. If you think this is valid, please create proper ticket.

malaskowski · 2018-09-24T10:08:05Z

report/src/main/webapp/app/services/endpointConfiguration.service.js

@@ -18,15 +18,21 @@
 define(['angularAMD'], function (angularAMD) {
  'use strict';
  angularAMD.factory('endpointConfiguration', function () {
+    var domain = 'http://aet-vagrant';


This can't be hardcoded! :)
Otherwise it won't work on different environments than http://aet-vagrant.
This is why getUrl returns relative url /api.
Please don't change this. Your domain is exactly the domain, at which this report is displayed.
Look how it is done in metadataEndpoint to call the endpoint without domain provided.

malaskowski · 2018-09-24T10:08:28Z

report/src/main/webapp/app/services/endpointConfiguration.service.js

+      },
+      getDomain: function () {
+        var config = {
+          'getUrl': domain
        };


Please look at my review comment. This can't be programmed like now.

malaskowski · 2018-09-24T10:10:14Z

report/src/main/webapp/app/services/rerun.service.js

+      var rerunParams = 'company=' + suiteInfo.company + '&' + 'project=' + suiteInfo.project + '&' +
+        'suite=' + suiteInfo.name + '&' + 'testName=' + testName;
+      var url = endpointConfiguration.getEndpoint().getUrl + 'suite-rerun?' + rerunParams;
+      console.log(url);


Please remove console.log, this shouldn't be used in production ready code in that form.

malaskowski · 2018-09-24T10:12:18Z

rest-endpoint/src/main/java/com/cognifide/aet/rest/BasicDataServlet.java

@@ -82,7 +82,7 @@ void unregister(String servletPath) {
    setHttpService(null);
  }

-  boolean isValidName(String suiteName) {
+  public static boolean isValidName(String suiteName) {


If those methods are used outside the servlet scope please extract them.
BasicDataServlet purpose shouldn't be mixed with Service/Helper that provide some common functionalities.

…e-way-to-execute-suite

… index wrapper

plutasnyy and others added 30 commits August 16, 2018 18:47

start work with rerun, create base for new servlet

a381d76

restored old annotataions, add register servlet

386273c

prototype

1526443

communication front - back

2e096a5

added test to payload

010593b

first version of endpoint to execute rerun

a6198eb

merge

556f061

restored addCors in suite rerun srvlet

e0bd59b

communication front - back refactor

fbd14d9

work on rerun servlet

956dcfa

Merge branch 'feature/rerun' of https://github.com/Cognifide/aet into…

278d22b

… feature/rerun

upadted suite executor

c22ccee

cleared data in received suite

f9d9660

small refactor to make servlet human readable

aa1d99d

added replacing test in database

fd39331

refactor

20395cb

refactor

48c1563

license & refactor

b421341

annotations fix

73b0abd

SuiteRerun update

6715f59

fixed clean daara from suite

988f255

changed overriding one test in mongo db from remove and add operation…

c020d2f

…s on update

merged with master, updated annotations to 6.0

d4b3350

removed scr from rest-endpoint and resolved conflicts

f7ca219

merged with history and resolved conflicts

bdf2fb9

added gson object in reponseAsJson calls

0765aae

resolved conflicts

deb4cc9

rerun all tests

140869e

Merge branch 'feature/rerun' of https://github.com/Cognifide/aet into…

0e9c74a

… feature/rerun

rerun button on suite level

fb8e612

plutasnyy added 3 commits September 13, 2018 16:04

changed formating

08bce92

changed urls

6b8667a

fixed NPE in get filters

c8451cf

plutasnyy commented Sep 16, 2018

View reviewed changes

plutasnyy added 5 commits September 17, 2018 11:15

added uid for full progress log

0c2cd28

added <T> for metadata run decorator

9bc6cde

fixed formatting

9af85c2

Merge branch 'milestone/rerun-one-test' into feature/rerun

5f60048

increase maxparams in eslint

74dba89

malaskowski suggested changes Sep 24, 2018

View reviewed changes

plutasnyy and others added 15 commits September 26, 2018 08:18

Merge remote-tracking branch 'origin/master' into feature/rerun-chang…

3e10020

…e-way-to-execute-suite

changed newArray to emptyList in getFilters function in comparator class

c97b06c

added uid to progress log

3a2f6ec

added parameter to RunIndexWrapper

5e1c2c3

fixed url in test executor documentation

dbc5a0d

moved static function to helper from basid data servlet

4403542

updated metadatao uid and way to calculate quantity urls in suite run…

ad910a5

… index wrapper

add parameter to metadata run decorator

69e6edd

resolve generic types for runindexwrapper

5621f56

fixed rerun url path

7eefd43

fixed type of meta data run in tests

cfb375f

added import to artifact srevlet after moved functions to other class

9b63cd6

removed consol logs

fa6784d

minor refactor types, added validation if test exist

bdbf8eb

added information about rerun after page refresh

37c8079

malaskowski approved these changes Oct 2, 2018

View reviewed changes

plutasnyy merged commit dedc37c into milestone/rerun-one-test Oct 2, 2018

plutasnyy mentioned this pull request Oct 24, 2018

Rerun suite, test, url #412

Merged

6 tasks

tMaxx deleted the feature/rerun branch August 6, 2020 14:15

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Rerun one test / Rerun suite #337

Rerun one test / Rerun suite #337

plutasnyy commented Aug 28, 2018

plutasnyy Sep 16, 2018 •

edited

Loading

malaskowski Sep 24, 2018

malaskowski Sep 24, 2018

plutasnyy Sep 16, 2018

malaskowski Sep 24, 2018

malaskowski Sep 24, 2018

malaskowski Sep 24, 2018

malaskowski Sep 24, 2018

malaskowski Sep 24, 2018

malaskowski Sep 24, 2018

malaskowski Sep 24, 2018

malaskowski Sep 24, 2018

malaskowski Sep 24, 2018

malaskowski Sep 24, 2018

malaskowski Sep 24, 2018

Rerun one test / Rerun suite #337

Rerun one test / Rerun suite #337

Conversation

plutasnyy commented Aug 28, 2018

Description

Screenshots (if appropriate):

Types of changes

Checklist:

plutasnyy Sep 16, 2018 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

plutasnyy Sep 16, 2018 •

edited

Loading