Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/minor frontend changes in rerun feature #395

Conversation

plutasnyy
Copy link
Contributor

Minor changes to make raport beautifull

Screenshots (if appropriate):

rerun screen

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

I hereby agree to the terms of the AET Contributor License Agreement.

@@ -274,3 +274,16 @@
.preformatted {
font-family: monospace;
}

.suite-rerun{

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Space before {

}

.suite-rerun-msg-font{
color: grey;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is grey used everywhere in app or could we use a color already used as variable?

font-size: 16px;
}

.suite-rerun-msg{

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there still html containig this class? Ive seen you removed one occurence in line 96, are there more?

@plutasnyy
Copy link
Contributor Author

Thanks! I changed all of it ;)

@plutasnyy plutasnyy merged commit 7ae5857 into milestone/rerun-one-test Oct 23, 2018
@malaskowski malaskowski deleted the feature/minor-frontend-changes-in-rerun-feature branch October 24, 2018 06:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants