Fixed issue with lack of clear message for erroneous suite definition #432
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
malaskowski
reviewed
Nov 20, 2018
client/client-scripts/aet.sh
Outdated
| @@ -81,8 +81,9 @@ function process_locked_suite { | |||
| ((UNLOCK_TIMEOUT-=5)) | |||
| start_suite | |||
| else | |||
| errorMessage=$(echo $body | jq -r ".errorMessage") | |||
| echo "Unsuccessful Request to \"$endpoint$SUITE_ENDPOINT\", status: $code | |||
There was a problem hiding this comment.
Could you please change the message to:
"Unsuccessful Request to "$endpoint$SUITE_ENDPOINT", status: $code, error: $errorMessage"
tkaik
added
the
QA Required
malaskowski
approved these changes
Nov 27, 2018
|
tested, working well ✔️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixed issue with lack of clear message for erroneous suite definition.
Motivation and Context
Before that fix, if there were errors in the response, they were returned in HTML format, containing a lot of unnecessary fluff.
This bugfix changes that, so that the response in JSON format is returned (as it has been the case for successful response). The aet.sh script has also been modified to accommodate that change.
ISSUE 414
Screenshots (if appropriate)
Upgrade notes (if appropriate)
Types of changes
Checklist:
I hereby agree to the terms of the AET Contributor License Agreement.