Bugfix/accessibility duplicates #439
Conversation
|
Separated position finding logic from the rest of the collector. |
| @@ -64,7 +63,8 @@ public CollectorStepResult collect() throws ProcessingException { | |||
| .getExecutionResultAsString(); | |||
| final String json = jsExecutor.execute(script, standard).getExecutionResultAsString(); | |||
| List<AccessibilityIssue> issues = parseIssues(json); | |||
| getElementsPositions(issues, html); | |||
| AccessibilityIssueMarkupFinder issuesFinder = new AccessibilityIssueMarkupFinder(html,issues); | |||
There was a problem hiding this comment.
How about moving parseIssues(json) logic to AccessibilityIssueMarkupFinder.
Then code here would look like:
List<AccessibilityIssue> issuesWithPositions = new AccessibilityIssueMarkupFinder(html, json).execute(); // or .find()/.get()/etc.| } | ||
|
|
||
| @Test | ||
| public void testSingleIssueNoOffset() { |
There was a problem hiding this comment.
Could you please adjust unit test naming convention to the AET tests-naming-convention?
There was a problem hiding this comment.
Please update line/column numbers in accessibility filters configured in integration-tests/test-suite/partials/accessibility-filtered.xml - probably after introdcuing your fix, the line/column location of errors will be different. Please test it on your branch by running the whole test-suite - you can find instructions in integration-tests/README.md
… into bugfix/accessibility-duplicates
…g indexed from 1)
| @@ -6,6 +6,9 @@ necessary configuration changes that were introduced in comparison to previously | |||
| You may see all changes in the [Changelog](https://github.com/Cognifide/aet/blob/master/CHANGELOG.md). | |||
|
|
|||
| ## Unreleased | |||
| Changes: | |||
| * Counting line and column number of an accessibility issue occurrence in [[Accessibility Collector|AccessibilityCollector]] has been improved. | |||
| Columns are now indexed starting from 1. Bug with two identical issues on a single page yielding the same line and column number has been fixed. | |||
There was a problem hiding this comment.
- Please provide some links here to related github issue(s) :)
- Pleasy explicitly explain here how users should change their suite.xml when upgrading from previous AET version - e.g. "When upgrading from previous AET version, you may need to decrease
columnvalue in by 1 and changelinevalue to match (...)"
malaskowski
added
the
QA Required
|
tested locally, working well ✔️ |
Fix line and column numbers duplicating in reports when multiple elements have the same HTML. (related to #438)
Description
My implementation scans document HTML starting from the latest occurrence of the same issue and not from the beginning of the document.
I hereby agree to the terms of the AET Contributor License Agreement.