Bugfix/resolution and subimage issues #518
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prevents RasterFormatException
…/resolution-and-subimage-issues
tkaik
reviewed
Aug 9, 2019
| if (point.getY() + height > fullImg.getHeight()) { | ||
| height = fullImg.getHeight() - point.getY(); | ||
| } | ||
| if (point.getX() + width == 0) { |
There was a problem hiding this comment.
I think that instead of those 2 if's, we can change if above to:
width = Math.max(1, fullImg.getWidth() - point.getX() (same for height)
…ssues' into bugfix/resolution-and-subimage-issues
plutasnyy
reviewed
Aug 9, 2019
| </urls> | ||
| </test> | ||
|
|
||
| <test name="S-comparator-Layout-Auto-Height-0px-Page"> |
There was a problem hiding this comment.
I am not 100% sure but with a change in integration tests you should also update https://github.com/Cognifide/aet/blob/master/integration-tests/sanity-functional/src/test/resources/features/filtering.feature or/and https://github.com/Cognifide/aet/blob/master/integration-tests/sanity-functional/src/test/java/com/cognifide/aet/sanity/functional/HomePageTilesTest.java
I remember that documentation contains some tutorial on how to run these tests but unfortunately I cannot find it :P
tkaik
approved these changes
Aug 14, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed bug in Resolution Modifier
Description
When user did not set
heightparameter, it is calculated automatically. To prevent error, minimum height is set to 1px, when site height is 0px.Motivation and Context
Closes #384
Screenshots (if appropriate)
Upgrade notes (if appropriate)
Types of changes
Checklist:
I hereby agree to the terms of the AET Contributor License Agreement.