Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add checks-effects-interactions violation detector. #134

Open
deuszx opened this issue Jul 25, 2023 · 0 comments
Open

Add checks-effects-interactions violation detector. #134

deuszx opened this issue Jul 25, 2023 · 0 comments
Labels
feature New feature or request

Comments

@deuszx
Copy link

deuszx commented Jul 25, 2023

https://docs.soliditylang.org/en/develop/security-considerations.html#use-the-checks-effects-interactions-pattern

I think it should be possible to write a detector for it? Since it maps nicely:

  1. Checks == if , assert , etc
  2. Effects == mutating state (either directly or by calling other &mut self methods)
  3. Interactions == *Ref::method or build_call

especially the last two are most important but also easiest to detect (🤞)

@faculerena faculerena added the feature New feature or request label Jul 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants