Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Previous-step total forces are calculated using current-step inverse gradients #83

Closed
giacomofiorin opened this issue Oct 11, 2016 · 1 comment
Assignees
Labels
bug To be used only in issues important

Comments

@giacomofiorin
Copy link
Member

To keep parallel performance high, total atomic forces cannot be communicated to Colvars until all calculations of a MD step come in. For this reason, total atomic forces are always those from the previous time step, and the total colllective force at step 0 is not available.

The total atomic forces are used to compute total collective forces (labeled as "ft" in the colvars.traj output) by using the inverse atomic gradients (IAGs). However, the IAGs are typically calculated using atomic gradients from the current time step. Such inconsistency creates a small error, which has affected total force calculation and ABF starting from early versions of the Colvars module. The same is true for the Jacobian term, which uses the current value of the collective variable.

A solution to this can be to compute the IAGs and the Jacobian term, store them in the atom_group container (see also #61), and use them at the beginning of the next MD step.

@giacomofiorin giacomofiorin self-assigned this Oct 17, 2016
@jhenin jhenin self-assigned this Oct 17, 2016
@jhenin jhenin added the bug To be used only in issues label Dec 10, 2016
@jhenin
Copy link
Member

jhenin commented Dec 10, 2016

Presumed fixed by 833c580.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug To be used only in issues important
Projects
None yet
Development

No branches or pull requests

2 participants