[BUG]? Popup does not wrap content (on Android)

[Dry-Tech]

Is there an existing issue for this?

• I have searched the existing issues

Did you read the "Reporting a bug" section on Contributing file?

• I have read the "Reporting a bug" section on Contributing file: https://github.com/CommunityToolkit/Maui/blob/main/CONTRIBUTING.md#reporting-a-bug

Current Behavior

Hello,
maybe I'm missing something very simple, but it seems that you can't use long texts as a label in a popup, because there is no line break and thus the popup will be wider than the display area.

I attached a sample repository and a screenshot.

Expected Behavior

Popup takes almost full width of the display because the text is so long, and the label text has line breaks when necessary.

Steps To Reproduce

1. Run the sample project
2. Click the button
3. You will see the result as shown in the screenshot

Link to public reproduction project repository

https://github.com/Dry-Tech/NetMauiPopupNoWrapBug

Environment

- .NET MAUI CommunityToolkit: 5.1.0
- OS: Android 10
- .NET MAUI: 7.0

Anything else?

[VladislavAntonyuk]

Try replacing VerticalStackLayout with Grid

[Dry-Tech]

Try replacing VerticalStackLayout with Grid

No sorry, did not work.

[pictos]

@Dry-Tech you can set a size on popup, if it doesn't measure as you would like. And you can force the word wrap using the Label.LineBreakMode property

[cat0363]

This issue may be resolved by PR #1361.

[cat0363]

In API Level 29 and below, the following method is used to obtain the height of the status bar, but this seems to be the problem.

[src\CommunityToolkit.Maui.Core\Views\Popup\PopupExtensions.android.cs]

decorView.GetWindowVisibleDisplayFrame(contentRect);
statusBarHeight = contentRect.Top;

When you call the above method, the Label will not wrap.
Although it is not very desirable, if you obtain the height of the status bar using the method introduced below, the label will be wrapped correctly. (This is the method I gave up on in PR #1320.)

var resourceIdStatus = decorView?.Context?.Resources?.GetIdentifier("status_bar_height", "dimen", "android") ?? 0;
statusBarHeight = resourceIdStatus > 0 ? decorView?.Context?.Resources?.GetDimensionPixelSize(resourceIdStatus) ?? 0 : 0;

If you can get the height of the status bar without calling the GetWindowVisibleDisplayFrame method, the problem for API Level 29 and below will be resolved.

Below are the results of the operation verification of the latest version of main.

[Use GetWindowVisibleDisplayFrame]

[Don't use GetWindowVisibleDisplayFrame]

API Level 30 and above is working as intended.
I'm looking into how to get the Statusbar height in API Level 29 and below, but I haven't found it yet.

Additional Information:
The label wrapping issue below API Level 29 can probably be resolved if you can get the status bar height without calling the GetWindowVisibleDisplayFrame method.

@brminnick , I would like to hear your opinion.

[cat0363]

@brminnick , I found a solution.

I found a way to calculate the status bar height without using the method below.
I will create a PR.

var resourceIdStatus = decorView?.Context?.Resources?.GetIdentifier("status_bar_height", "dimen", "android") ?? 0;
statusBarHeight = resourceIdStatus > 0 ? decorView?.Context?.Resources?.GetDimensionPixelSize(resourceIdStatus) ?? 0 : 0;