Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RangeSelector] on WASM draws squares around track controls #386

Closed
3 of 24 tasks
xperiandri opened this issue Mar 29, 2024 · 6 comments · Fixed by #400
Closed
3 of 24 tasks

[RangeSelector] on WASM draws squares around track controls #386

xperiandri opened this issue Mar 29, 2024 · 6 comments · Fixed by #400
Labels
external ⤴️ Requires an update to an external dependency or due to code outside the Toolkit. Uno Issues related to Uno Platform ux 🖌️ Everything design related
Milestone

Comments

@xperiandri
Copy link

Describe the bug

image

Steps to reproduce

Create a blank Uno app
Add a `RangeSelector` to the main page
Launch WASM head

Expected behavior

No square borders around track controls

Screenshots

No response

Code Platform

  • UWP
  • WinAppSDK / WinUI 3
  • Web Assembly (WASM)
  • Android
  • iOS
  • MacOS
  • Linux / GTK

Windows Build Number

  • Windows 10 1809 (Build 17763)
  • Windows 10 1903 (Build 18362)
  • Windows 10 1909 (Build 18363)
  • Windows 10 2004 (Build 19041)
  • Windows 10 20H2 (Build 19042)
  • Windows 10 21H1 (Build 19043)
  • Windows 10 21H2 (Build 19044)
  • Windows 10 22H2 (Build 19045)
  • Windows 11 21H2 (Build 22000)
  • Other (specify)

Other Windows Build number

No response

App minimum and target SDK version

  • Windows 10, version 1809 (Build 17763)
  • Windows 10, version 1903 (Build 18362)
  • Windows 10, version 1909 (Build 18363)
  • Windows 10, version 2004 (Build 19041)
  • Windows 10, version 2104 (Build 20348)
  • Windows 11, version 22H2 (Build 22000)
  • Other (specify)

Other SDK version

No response

Visual Studio Version

2022

Visual Studio Build Number

No response

Device form factor

No response

Additional context

No response

Help us help you

Yes, but only if others can assist.

@Arlodotexe
Copy link
Member

Looks like Uno had fixed this in this PR. This can be reproduced over in https://toolkitlabs.dev, which is using the latest version of Uno from our main branch. This appears to be a regression in Uno.

@michael-hawker
Copy link
Member

This is an Uno issue, their bug is here: unoplatform/uno#10263, it was supposed to have been fixed, hmm.

@Arlodotexe Arlodotexe added this to the 8.1 Update 1 milestone Apr 2, 2024
@michael-hawker michael-hawker added external ⤴️ Requires an update to an external dependency or due to code outside the Toolkit. Uno Issues related to Uno Platform ux 🖌️ Everything design related labels Apr 2, 2024
@xperiandri
Copy link
Author

So why do they appear if it is fixed?
Or is not it fixed?

@michael-hawker
Copy link
Member

So why do they appear if it is fixed? Or is not it fixed?

It was supposedly fixed, but that appears to not be the case. I thought I had seen this work in the interim at one point, so maybe it regressed again. I poked the Uno issue, so that's going to be the best place to follow-up.

@xperiandri
Copy link
Author

Thanks

@MartinZikmund
Copy link
Contributor

The linked issue is not related, we are tracking this in unoplatform/uno#15448, will prioritize it to get the fix out asap

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
external ⤴️ Requires an update to an external dependency or due to code outside the Toolkit. Uno Issues related to Uno Platform ux 🖌️ Everything design related
Projects
Status: Done
4 participants