Refactor CyclotomicSquare method into template generator, minor clean-up #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…te generator for bls381 only
…te generator for bls377
…e generator for bn256; worked out of the box! Bwahahaaa!
…esidueInv from fp2 for bw761
ggutoski
requested review from
gbotrel and
ThomasPiellard
and removed request for
gbotrel
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Title says it all. See commit history. "Clean-up" includes:
MulByNonResidue,MulByNonResidueInvmethods in the template generatorpairing.goMulByNonResidue. (This optimization was already present elsewhere in bls381, just not inMulByNonResidue.)