Fix/fft cosets #145
Merged
Fix/fft cosets #145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gbotrel
requested changes
Feb 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR modifes the FFT so the cosets are taken in Fr* \ (Z/2^nZ) where (Z/2^nZ) is identified with the maximum power-of-two multiplicative subgroup of Fr*, instead of being taken in in (Z/2^nZ) which prevented us from using the full two-adicity.
Plookup, permutation argument, etc have been modified accordingly.
API breaking changes:
NewDomain(m, depth uint64, precomputeReversedTable bool)->NewDomain(m)FFT(a []fr.Element, decimation Decimation, coset uint64)->FFT(a []fr.Element, decimation Decimation, coset ...bool). When coset is specified and set totrue, the FFT is done on a coset (precomputed and not up to the user).It fixes #145 .